Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app-shell-odd): push: proper deps ordering #16968

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

sfoster1
Copy link
Member

Make does recipe dependences left to right. This fixes an issue where pushes would push a stale frontend.

Make does recipe dependences left to right. This fixes an issue where
pushes would push a stale frontend.
@sfoster1 sfoster1 requested a review from mjhuff November 25, 2024 14:42
@sfoster1 sfoster1 requested a review from a team as a code owner November 25, 2024 14:42
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sfoster1 sfoster1 merged commit b6e29e9 into edge Nov 25, 2024
34 checks passed
@sfoster1 sfoster1 deleted the chore-fix-makefile-deps branch November 25, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants