Skip to content

Commit

Permalink
fix(opentrons-ai-client, instrument-pipette): removing GEN1 pipettes (#…
Browse files Browse the repository at this point in the history
…16993)

<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview
Since we do not use GEN1 pipettes, we are removing them from the UI.

Closes AUTH-1111

<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing
Have a look at the UI and verify that only GEN2 pipettes are present.

<img width="942" alt="image"
src="https://github.com/user-attachments/assets/a14463e1-144d-4407-a419-f3ce92cb68d4">


<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog
- filter out GEN1 pipettes
<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests
See above
<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment
Low
<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
  • Loading branch information
Elyorcv authored Nov 27, 2024
1 parent bd0b634 commit ffc0291
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ export function InstrumentsSection(): JSX.Element | null {
name
)
)
.filter(name => {
const specs = getPipetteSpecsV2(name)
return !specs?.displayName?.includes('GEN1')
})
.map(name => ({
value: name,
name: getPipetteSpecsV2(name)?.displayName ?? '',
Expand Down

0 comments on commit ffc0291

Please sign in to comment.