Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement feedback for M-01, L-08, L-09 #5324

Merged
merged 15 commits into from
Nov 29, 2024
Merged

Implement feedback for M-01, L-08, L-09 #5324

merged 15 commits into from
Nov 29, 2024
+99 −23

Conversation

ernestognw
Copy link
Member

Implement feedback from audit review of previous issues

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 63c2da9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Amxx
Amxx reviewed Nov 27, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
Amxx
Amxx reviewed Nov 27, 2024
View reviewed changes
contracts/proxy/Clones.sol Outdated Show resolved Hide resolved
@Amxx Amxx added this to the 5.2-after-freeze milestone Nov 27, 2024
@Amxx Amxx mentioned this pull request Nov 27, 2024
Open
3 tasks
Amxx
Amxx reviewed Nov 28, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
Amxx
Amxx reviewed Nov 28, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
Amxx
Amxx reviewed Nov 28, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
Amxx
Amxx reviewed Nov 28, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
Amxx
Amxx reviewed Nov 28, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
Amxx
Amxx reviewed Nov 28, 2024
View reviewed changes
contracts/utils/Strings.sol Outdated Show resolved Hide resolved
Amxx
Amxx previously approved these changes Nov 28, 2024
View reviewed changes
@ernestognw ernestognw merged commit 78be1b3 into OpenZeppelin:master Nov 29, 2024
17 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Nov 30, 2024
@ernestognw @Amxx
Implement feedback for M-01, L-08, L-09 (OpenZeppelin#5324)
17d2dee 
Co-authored-by: Hadrien Croubois <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Nov 30, 2024
@ernestognw @Amxx
Implement feedback for M-01, L-08, L-09 (OpenZeppelin#5324)
4299784 
Co-authored-by: Hadrien Croubois <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.2-after-freeze
Development

Successfully merging this pull request may close these issues.
2 participants
@ernestognw @Amxx