Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governor: Sequential Proposal Ids #5290

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Governor: Sequential Proposal Ids #5290

wants to merge 30 commits into from

Commits on Oct 25, 2024

  1. feat: governor sequential proposal id

    @arr00
    arr00 committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a25d139 View commit details
    Browse the repository at this point in the history

  2. use super hash

    @arr00
    arr00 committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a4ee283 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Make numberOfProposals private

    @arr00
    arr00 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e34a8b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Update contracts/governance/extensions/GovernorSequentialProposalId.sol 

    Co-authored-by: Hadrien Croubois <[email protected]>
    @arr00 @Amxx
    arr00 and Amxx authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3cf1b80 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. use internal getProposalId function

    @arr00
    arr00 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9063080 View commit details
    Browse the repository at this point in the history

  2. hash proposal is view

    @arr00
    arr00 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8755aa6 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Add _setNextProposalId helper func

    @arr00
    arr00 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c52f001 View commit details
    Browse the repository at this point in the history

  2. Revert if next proposal id set and current proposal not 0

    @arr00
    arr00 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d9f3477 View commit details
    Browse the repository at this point in the history

  3. Add getNextProposalId func

    @arr00
    arr00 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b063a61 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Add view function getProposalId

    @arr00
    arr00 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    19dfdf8 View commit details
    Browse the repository at this point in the history

  2. Set proposal count instead of next

    @arr00
    arr00 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    185b6a3 View commit details
    Browse the repository at this point in the history

  3. tests

    @Amxx
    Amxx committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    cb91e76 View commit details
    Browse the repository at this point in the history

  4. revert when calling getProposalId before propose

    @Amxx
    Amxx committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    5ff56da View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Rename getProposalCount to proposalCount

    @arr00
    arr00 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f0e9fb5 View commit details
    Browse the repository at this point in the history

  2. Update test/helpers/governance.js

    @Amxx
    Amxx authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    becc77a View commit details
    Browse the repository at this point in the history

  3. fix test

    @arr00
    arr00 committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8ffad72 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. add patch

    @arr00
    arr00 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3e49fb9 View commit details
    Browse the repository at this point in the history

  2. fix repropose bug

    @arr00
    arr00 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    41d49c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. interface Id

    @Amxx
    Amxx committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f8cfe02 View commit details
    Browse the repository at this point in the history

  2. code style uniformity

    @Amxx
    Amxx committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    76d57a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. require proposal count to be strictly increasing

    @arr00
    arr00 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    74bdb35 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/sequential-proposal-id-alt-2

    @arr00
    arr00 authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3206080 View commit details
    Browse the repository at this point in the history

  3. update comment

    @arr00
    arr00 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c174090 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. only allow setting the proposal count from 0

    @arr00
    arr00 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    9786e76 View commit details
    Browse the repository at this point in the history

  2. update docs

    @arr00
    arr00 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    df711fe View commit details
    Browse the repository at this point in the history

  3. fix test

    @arr00
    arr00 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a04b47f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Update contracts/governance/IGovernor.sol 

    Co-authored-by: Ernesto García <[email protected]>
    @arr00 @ernestognw
    arr00 and ernestognw authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2de3660 View commit details
    Browse the repository at this point in the history

  2. move proposalCount

    @arr00
    arr00 committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    da959cd View commit details
    Browse the repository at this point in the history

  3. reuse governor interface

    @arr00
    arr00 committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e037708 View commit details
    Browse the repository at this point in the history

  4. add coverage

    @arr00
    arr00 committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    fdea2cc View commit details
    Browse the repository at this point in the history