Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added network support for holesky #695

Merged
merged 4 commits into from
Jan 15, 2024
Merged

added network support for holesky #695

merged 4 commits into from
Jan 15, 2024

Conversation

basefee
Copy link
Contributor

@basefee basefee commented Nov 16, 2023

This pull request make the following changes:

@GianfrancoBazzani GianfrancoBazzani self-assigned this Jan 12, 2024
GianfrancoBazzani
GianfrancoBazzani approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@GianfrancoBazzani GianfrancoBazzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GianfrancoBazzani
Copy link
Member

GianfrancoBazzani commented Jan 13, 2024 •
edited
Loading

Hey @garv-aga thanks for your contribution! ^^. We need to receive the ownership of the statistics ProxyAdmin contract before merge the PR.

Please transfer the ownership of 0x8f3189256cb686D0aCD642bAa3982Fda156fB01D to Ethernaut's owner address: 0x09902A56d04a9446601a0d451E07459dC5aF0820

@basefee
Copy link
Contributor Author

basefee commented Jan 13, 2024 •
edited
Loading

Screenshot_20240113_160933

Hey @garv-aga thanks for your contribution! ^^. We need to receive the ownership of the statistics ProxyAdmin contract before merge the PR.

Please transfer the ownership of 0x8f3189256cb686D0aCD642bAa3982Fda156fB01D to Ethernaut's owner address: 0x09902A56d04a9446601a0d451E07459dC5aF0820

I transferred the ownership.

Thanks for the opportunity

@xaler5
Copy link
Collaborator

xaler5 commented Jan 15, 2024

LGTM! thanks ❤️

@xaler5 xaler5 merged commit a8d7e99 into OpenZeppelin:master Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GianfrancoBazzani GianfrancoBazzani GianfrancoBazzani approved these changes

@xaler5 xaler5 xaler5 approved these changes

Assignees

@GianfrancoBazzani GianfrancoBazzani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basefee @GianfrancoBazzani @xaler5