network-slave: Retry ip rule add #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip rule add has been seen to fail: VM Network (1): network-slave: exception: "command: "ip rule add pref 104 iif brshared table rt-brbridged" FAILED." while processing RPC "configure" It is unknown why this happened. Instead of being fatal, retry and also print the error message. Have not re-triggered a failure with this change. Signed-off-by: Jason Andryuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip rule add has been seen to fail:
VM Network (1): network-slave: exception: "command: "ip rule add pref 104 iif brshared table rt-brbridged" FAILED." while processing RPC "configure"
It is unknown why this happened.
Instead of being fatal, retry and also print the error message. Have not re-triggered a failure with this change.
The
iptables -wfailures I was able to reason about. This one I don't know why it happened and don't have any clues to go on. So adding the retries may just keep failing. Shouldn't be worse than just failing once though?Since I haven't re-triggered the failure, the retry logic is untested. If it did fail, we should get the error output which would help further investigation.