Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3.12 support #6

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

py3.12 support #6

wants to merge 1 commit into from

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented May 24, 2024

allows the plugin to install. but we need to figure out

Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]: 2024-03-15 17:24:48.631 - voice - ovos_plugin_manager.wakewords:load_module:165 - INFO - Loading "wake_up" wake word via ovos-ww-plugin-pocketsphinx with config: {'module': 'ovos-ww-plugin-pocketsphinx', 'phonemes': 'W EY K . AH P', 'threshold': 1e-20, 'lang': 'en-us', 'wakeup': True, 'fallback_ww': 'wake_up_vosk'}
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]: 2024-03-15 17:24:48.641 - voice - ovos_plugin_manager.wakewords:load_module:172 - INFO - Loaded the Wake Word wake_up with module ovos-ww-plugin-pocketsphinx
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]: ERROR: "ps_config.c", line 158: Only one of lm, jsgf, fsg, keyphrase, kws, allphone, lmctl, can be enabled at a time in config
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]: 2024-03-15 17:24:48.642 - voice - ovos_plugin_manager.wakewords:create_hotword:196 - ERROR - Failed to load hotword: wake_up - ovos-ww-plugin-pocketsphinx
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]: 2024-03-15 17:24:48.642 - voice - ovos_plugin_manager.wakewords:create_hotword:197 - ERROR - Failed to initialize PocketSphinx
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]: Traceback (most recent call last):
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_plugin_manager/wakewords.py", line 194, in create_hotword
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:     return cls.load_module(module, hotword, ww_config, lang, loop)
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_plugin_manager/wakewords.py", line 173, in load_module
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:     return clazz(hotword, hotword_config, lang=lang)
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:   File "/home/goldyfruit/.venvs/ovos/lib/python3.11/site-packages/ovos_ww_plugin_pocketsphinx/__init__.py", line 54, in __init__
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:     self.decoder = Decoder(config)
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:                    ^^^^^^^^^^^^^^^
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]:   File "_pocketsphinx.pyx", line 852, in _pocketsphinx.Decoder.__init__
Mar 15 17:24:48 rpi5b03 ovos-dinkum-listener[82281]: RuntimeError: Failed to initialize PocketSphinx

no migration guide, just this https://cmusphinx.github.io/2022/09/release-candidate-4/

Python code is entirely unaffected by these changes

obviously not the case 🙃

related cmusphinx/pocketsphinx#386

@JarbasAl JarbasAl added the bug Something isn't working label May 24, 2024
@JarbasAl JarbasAl requested a review from goldyfruit May 24, 2024 02:18
JarbasAl added a commit to OpenVoiceOS/ovos-dinkum-listener that referenced this pull request May 30, 2024
move to vosk plugin instead, only used for "wake up" in naptime mode, already accounted for in default mycroft.conf if pocketsphinx isnt available

pocketsphinx is unmaintained and latest version broke the plugin OpenVoiceOS/ovos-ww-plugin-pocketsphinx#6 

this also brings support for py3.12
JarbasAl added a commit to OpenVoiceOS/ovos-dinkum-listener that referenced this pull request May 30, 2024
* drop pocketsphinx

move to vosk plugin instead, only used for "wake up" in naptime mode, already accounted for in default mycroft.conf if pocketsphinx isnt available

pocketsphinx is unmaintained and latest version broke the plugin OpenVoiceOS/ovos-ww-plugin-pocketsphinx#6 

this also brings support for py3.12

* Update requirements.txt

* keep stable version
@JarbasAl JarbasAl marked this pull request as draft June 20, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant