Fix: Remove generated .sfo file on clean #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Mar 19, 2024
Makefile.in
Outdated
| @@ -9,7 +9,7 @@ | |||
| > $@ | |||
| $(_V) [ -z "$(UNIX2DOS)" ] || $(UNIX2DOS) $(UNIX2DOS_FLAGS) $@ | |||
|
|
|||
| MD5SUM ?= $(shell command -v md5sum 2>/dev/null) | |||
| MD5SUM ?= $(shell which md5sum 2>/dev/null) | |||
There was a problem hiding this comment.
I thought the general trend in packaging was to remove which usages
There was a problem hiding this comment.
Hm, that could be. I cannot actually recall why I made this change in the first place, and the commit message does not mention it (which is unlike me), so I suspect I just accidentally put this change in this commit (which is also unlike me). This change is also not in the package I'm shipping in the Debian package, so it does not seem to be required there either.
In any case, I've force pushed an update to remove this change, leaving just the .sfo removal (and rebasing the PR at the same time).
Thanks!
matthijskooijman
force-pushed
the
fix-clean-sfo
branch
from
28ce1f0
to
98a344a
Compare
LordAro
approved these changes
Mar 20, 2024
This fixes a part of OpenTTD#47.
matthijskooijman
force-pushed
the
fix-clean-sfo
branch
from
98a344a
to
16ecf96
Compare
|
Did another rebase, the CI now passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a part of #47.