Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Menambahkan error handler global untuk error #11

Merged

Conversation

NurfitraPujo
Copy link
Member

@NurfitraPujo NurfitraPujo commented Dec 20, 2021

Pekerjaan selesai

  • Menambahkan error handler untuk menangkap error yang tidak terhandle sehingga
  • Menambahkan konstan HttpStatus

Catatan
Error yang berasal dari operasi asinkron tidak bisa tercover karena express tidak dapat menghandle operasi asinkron secara native. Opsi yang bisa dilakukan :

  1. migrate pakai koa / yang lain
  2. mengoverride tiap2 handler express agar bisa handle asinkron
  3. menambahkan try catch di setiap operasi asinkron

@NurfitraPujo NurfitraPujo added the enhancement New feature or request label Dec 20, 2021
@NurfitraPujo NurfitraPujo added this to the MVP milestone Dec 20, 2021
@NurfitraPujo NurfitraPujo self-assigned this Dec 20, 2021
@NurfitraPujo NurfitraPujo linked an issue Dec 20, 2021 that may be closed by this pull request
2 tasks
Copy link
Member

@algonacci algonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved yaa

@algonacci algonacci merged commit a8a1def into OpenProjects-id:develop Dec 20, 2021
@NurfitraPujo NurfitraPujo deleted the feature/global-error-handler branch December 20, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menambahkan global error handler
2 participants