Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disambiguate tool to QC portion of the weave pipeline #33

Merged
merged 9 commits into from
Jan 16, 2024

Conversation

rroutsong
Copy link
Collaborator

Partially addresses #25

This pull request implements disambiguate when a command line user identifies a valid host genome using the --host[-t] and pathogen genome by the --pathogen[-p] flags. If does not use a valid fasta, or gzipped fasta, genome an error will be raised.

Currently this implementation of disambiguate only uses bwa mem for alignment. This will need to change in the future including a method of detecting whether a cohort is DNA [bwa mem or support bowtie2] or RNA [STAR-aligner].

Copy link
Contributor

@skchronicles skchronicles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can address some of the comments outlined within the next PR, that would be perfect!

.github/workflows/doc.yml Outdated Show resolved Hide resolved
weave Outdated Show resolved Hide resolved
workflow/qc.smk Outdated Show resolved Hide resolved
docker/NGS_QC/Dockerfile Show resolved Hide resolved
Copy link
Contributor

@skchronicles skchronicles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@skchronicles skchronicles merged commit b13c507 into main Jan 16, 2024
2 checks passed
@skchronicles skchronicles deleted the add_disambig branch February 1, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants