Remove Mage_Sendfriend

[sreichel]

Description (*)

• see Does anyone use Mage_Sendfriend? #4186
• see https://github.com/OpenMage/module-mage-sendfriend

[kiatng]

Orphaned references

in Mage_Adminhtml:

magento-lts/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Checktype.php

Lines 32 to 39 in a5a8527

	[
	'value' => Mage_Sendfriend_Helper_Data::CHECK_IP,
	'label' => Mage::helper('adminhtml')->__('IP Address')
	],
	[
	'value' => Mage_Sendfriend_Helper_Data::CHECK_COOKIE,
	'label' => Mage::helper('adminhtml')->__('Cookie (unsafe)')
	],

email template:
https://github.com/OpenMage/magento-lts/blob/main/app/locale/en_US/template/email/product_share.html

ACL resource:

magento-lts/app/code/core/Mage/Adminhtml/etc/adminhtml.xml

Lines 200 to 203 in a5a8527

	<sendfriend translate="title">
	<title>Email to a Friend</title>
	<sort_order>140</sort_order>
	</sendfriend>

However, removing the above would break Mage_Sendfriend if install from composer.

[kiatng]

Alternative extension: https://github.com/pyrroman/social-sharing-button-for-magento

[sreichel]

@kiatng Thanks. I have seen that sendfriend has some references in Mage_Reports observers, but i completly missed that.

[sreichel]

Alternative extension: https://github.com/pyrroman/social-sharing-button-for-magento

Thanks. This will be mentioned in documention :)

[sreichel]

There is also ...

class Mage_Catalog_Model_Resource_Eav_Mysql4_Sendfriend extends Mage_Sendfriend_Model_Resource_Sendfriend

[sreichel]

Alternative extension: https://github.com/pyrroman/social-sharing-button-for-magento

Added to #4156

[sreichel]

However, removing the above would break Mage_Sendfriend if install from composer.

What is the problem with it?

Please test

ddev composer localdev https://github.com/OpenMage/module-mage-sendfriend
ddev composer require openmage/module-mage-sendfriend:dev-main

[ADDISON74]

I hope the PR covers all records and nothing is left behind.

[sreichel]

I can ensure there is code left behind. Observer from Mage_Reports eg ... but nothing that should rely on removed code.

[colinmollenhour]

Looks good! Thanks!

[ADDISON74]

@sreichel - Why these files still remain, having no content, instead of being deleted as well?

• app/design/frontend/rwd/default/template/sendfriend/send.phtml
• app/design/frontend/base/default/template/sendfriend/send.phtml

Both are mentioned in the layout file app/design/frontend/base/default/layout/sendfriend.xml which you deleted.

Also, there is a conflict to be solved related to the app/code/core/Mage/Sendfriend/etc/system.xml file.

[sreichel]

For some reasons they have been restored in eb475d9.

Removed.

[ADDISON74]

@sreichel - I checkout this branch and there are two directories left behind

/app/code/core/Mage/Sendfriend
/app/code/core/Mage/Sendfriend/sql

I reloaded from disk a few times to be sure. If I am wrong a double check is welcome.