Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for DCQCN #54

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix regex for DCQCN #54

merged 1 commit into from
Oct 25, 2023

Conversation

velomatt
Copy link
Contributor

  • skip task if regex does not match
  • won't fail if the regex doesn't match now

- skip task if regex does not match
- won't fail if the regex doesn't match now
@velomatt velomatt requested a review from a team as a code owner September 20, 2023 22:38
@velomatt
Copy link
Contributor Author

Low risk changes. Only applies to configure_vlans play.

Was previously failing when attempting to configure a host with ConnectX 4 adapters. Now those adapters will be skipped and not fail with a cryptic error.

@mssawant
Copy link

mssawant commented Sep 20, 2023

@velomatt , trying to understand the problem and the solution, since we needed to add the connectX-4 adapters before, why are we silently skipping them now?

[suggestion] I think, Was previously failing when attempting to configure a host with ConnectX 4 adapters. Now those adapters will be skipped and not fail with a cryptic error. would help to be part of the commit message problem statement.

@velomatt
Copy link
Contributor Author

@velomatt , trying to understand the problem and the solution, since we needed to add the connectX-4 adapters before, why are we silently skipping them now?

[suggestion] I think, Was previously failing when attempting to configure a host with ConnectX 4 adapters. Now those adapters will be skipped and not fail with a cryptic error. would help to be part of the commit message problem statement.

This bugfix is not specific to ConnectX 4 adapters, I'm just giving an example of where I encountered this error. This error can potentially happen with any Mellanox adapter if it does not have the specific DCQCN parameters we are tuning for maximum performance.

Copy link

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@velomatt velomatt merged commit fe70a76 into master Oct 25, 2023
1 check passed
@velomatt velomatt deleted the fix-dcqcn-regex branch October 25, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants