Skip to content

Commit

Permalink
changes in spec
Browse files Browse the repository at this point in the history
Signed-off-by: tnazarew <[email protected]>
  • Loading branch information
tnazarew committed Oct 23, 2024
1 parent d00f96e commit bc19e31
Show file tree
Hide file tree
Showing 7 changed files with 56 additions and 5 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/check_scenarios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
get-latest-snapshots:
description: "Should the artifact be downloaded from maven repo or circleci"
type: string
fail-for-failures:
description: "should the job fail if there are failures in tests"
type: boolean

jobs:
run-scenario-tests:
Expand All @@ -33,6 +36,7 @@ jobs:

- name: fail for failures in report
id: fail-for-failures
if: ${{ inputs.fail-for-failures }}
run: |
jq -e '.scenarios.status == "SUCCESS"' downloads/scenario-report.json > /dev/null || exit 1
5 changes: 1 addition & 4 deletions .github/workflows/main_ol_spec_changes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ jobs:
with:
release: ${{ needs.initialize_workflow.outputs.ol_release }}
get-latest-snapshots: 'true'
fail-for-failures: false

# check if producers still produce compatible events
spark-dataproc:
Expand All @@ -102,7 +103,3 @@ jobs:
needs: collect-and-compare-reports
uses: ./.github/workflows/notify_maintainers.yml

generate-compatibility-tables:
needs: collect-and-compare-reports
uses: ./.github/workflows/generate_compatibility_tables.yml

2 changes: 1 addition & 1 deletion .github/workflows/notify_maintainers.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Notify Maintainers
# TODO update from placeholder to actual functionality

on:
workflow_call:

Expand Down
8 changes: 8 additions & 0 deletions consumer/scenarios/CLL/maintainers.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[
{
"type": "maintainer",
"github-name": "tnazarew",
"email": "[email protected]",
"link": ""
}
]
14 changes: 14 additions & 0 deletions consumer/scenarios/simple_run_event/maintainers.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[
{
"type": "maintainer",
"github-name": "ddebowczyk92",
"email": "[email protected]",
"link": ""
},
{
"type": "maintainer",
"github-name": "tnazarew",
"email": "[email protected]",
"link": ""
}
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[
{
"type": "maintainer",
"github-name": "ddebowczyk92",
"email": "[email protected]",
"link": ""
},
{
"type": "maintainer",
"github-name": "tnazarew",
"email": "[email protected]",
"link": ""
}
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[
{
"type": "maintainer",
"github-name": "ddebowczyk92",
"email": "[email protected]",
"link": ""
},
{
"type": "maintainer",
"github-name": "tnazarew",
"email": "[email protected]",
"link": ""
}
]

0 comments on commit bc19e31

Please sign in to comment.