Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port MYFACES-4679 to 2.2 #29647

Open
wants to merge 3 commits into
base: integration
Choose a base branch
from
Open

Port MYFACES-4679 to 2.2 #29647

wants to merge 3 commits into from

Conversation

volosied
Copy link
Member

@volosied volosied commented Sep 13, 2024 •
edited
Loading

fixes #29648 (2.3+ will be fixed via #30276)

ID Review is NOT needed as I'm only removing copyrights from the messages files (to match upstream since really shouldn't be licensed under EPL 2.0)

@volosied volosied added regression This bug is for something that worked in a past release, but no longer does release bug This bug is present in a released version of Open Liberty labels Sep 13, 2024
@volosied volosied self-assigned this Sep 13, 2024
@volosied
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=ec2d6996-474c-4c57-bfbe-df7caa8a8235

Target locations of links might be accessible only to IBM employees.

@volosied volosied marked this pull request as draft September 13, 2024 18:12
@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_-l3EMnH1Ee-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=ec2d6996-474c-4c57-bfbe-df7caa8a8235 has errors/failures.

@LibbyBot
Copy link

The build volosied-29647-20240913-1837
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_-l3EMnH1Ee-0ZL4JeBVc2g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_-l3EMnH1Ee-0ZL4JeBVc2g

@dmuelle
Copy link
Member

dmuelle commented Sep 17, 2024

Hi @volosied - are there new messages here that need ID review? If not you can add the ID review not needed label to bypass review. I do notice though that Messages.js looks odd, the metadata us being deleted and all the message file content appears to be on a single line

@dmuelle
Copy link
Member

dmuelle commented Sep 17, 2024

sorry, just noticed this is still in draft, feel free to disregard my comment if not ready

@volosied volosied force-pushed the MYFACES-4679 branch 3 times, most recently from fd60f0c to c845135 Compare October 16, 2024 20:09
@volosied volosied marked this pull request as ready for review November 19, 2024 20:52
@volosied
Copy link
Member Author

#build #spawn.fullfat.buckets=com.ibm.ws.jsf_fat_lWAS_faces3.0,com.ibm.ws.jsf_fat_lWAS_faces4.0,com.ibm.ws.jsf_fat_lWAS,com.ibm.ws.jsf.2.2_fat,com.ibm.ws.jsf.2.2_fat.2,com.ibm.ws.jsf.2.3_fat

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=9e10cf97-cb69-4332-b914-5114b5e271d7

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=9e10cf97-cb69-4332-b914-5114b5e271d7 has errors/failures.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ldlN4KcLEe-WbLf72iZSEQ

Target locations of links might be accessible only to IBM employees.

@volosied
Copy link
Member Author

#build #spawn.fullfat.buckets=com.ibm.ws.jsf_fat_lWAS_faces3.0,com.ibm.ws.jsf_fat_lWAS_faces4.0,com.ibm.ws.jsf_fat_lWAS,com.ibm.ws.jsf.2.2_fat,com.ibm.ws.jsf.2.2_fat.2,com.ibm.ws.jsf.2.3_fat

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=e6c4ca39-b543-4bca-b3f0-6feb7bd850fe

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=e6c4ca39-b543-4bca-b3f0-6feb7bd850fe has errors/failures.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_XMdjoKi2Ee-WbLf72iZSEQ

Target locations of links might be accessible only to IBM employees.

@volosied
Copy link
Member Author

Build: https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_gDTIAKjjEe-Dk-P4EefJ2g

@volosied volosied force-pushed the MYFACES-4679 branch 3 times, most recently from 193f1ff to 8af32d3 Compare November 25, 2024 19:09
pnicolucci
pnicolucci previously approved these changes Nov 25, 2024
View reviewed changes
@pnicolucci
Copy link
Member

#libby

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=57e7300b-d929-4f89-9732-8fab2f651191

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=57e7300b-d929-4f89-9732-8fab2f651191 has errors/failures.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 94 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 7 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 20 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_fr.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_HK.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_nl.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_it.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_CN.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_TW.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_de.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_CN.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_fr.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_de.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_TW.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_nl.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_it.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_es.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_ru.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_es.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/internal-resources/javax.faces/META-INF/resources/myfaces/_impl/i18n/Messages_zh_HK.js

  • dev/com.ibm.websphere.javaee.jsf.2.2/src/META-INF/resources/myfaces/META-INF/resources/myfaces/_impl/i18n/Messages_ru.js

@volosied
Copy link
Member Author

New Build: https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_phD3EKzBEe-5Tq7vYMk6IA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicolucci pnicolucci pnicolucci approved these changes

@dmuelle dmuelle Awaiting requested review from dmuelle

Assignees

@volosied volosied

Labels
CLA Signed ID review not needed L2 ReviewNotRequired regression This bug is for something that worked in a past release, but no longer does release bug This bug is present in a released version of Open Liberty
Projects
Web Tier Team
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix MYFACES-4679 / PH63238 in JSF (Ajax Invokes Actions Unintentionally) in JSF 2.2
5 participants
@volosied @LibbyBot @dmuelle @pnicolucci @posmith