Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #264 - Fixes for manually added projects not being listed in the dashboard after re-opening IDE or workspace #372

Merged

Conversation

JoshwinThomasIBM
Copy link
Contributor

Fixes #264 Changes include the user being asked for saving the workspace when they try to add a project to the dashboard manually

src/definitions/constants.ts Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/liberty/libertyProject.ts Outdated Show resolved Hide resolved
src/liberty/libertyProject.ts Outdated Show resolved Hide resolved
src/liberty/devCommands.ts Outdated Show resolved Hide resolved
src/liberty/libertyProject.ts Outdated Show resolved Hide resolved
src/liberty/libertyProject.ts Show resolved Hide resolved
src/liberty/libertyProject.ts Show resolved Hide resolved
src/liberty/libertyProject.ts Outdated Show resolved Hide resolved
src/util/helperUtil.ts Show resolved Hide resolved
aparnamichael
aparnamichael previously approved these changes Nov 22, 2024
src/liberty/dashboard.ts Outdated Show resolved Hide resolved
src/liberty/libertyProject.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@TrevCraw TrevCraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please open an issue for what was discussed in this thread: #372 (comment). Make sure to reference that thread in the issue. Thanks!

@JoshwinThomasIBM
Copy link
Contributor Author

Created the issues for the discussed ones - 394,395,396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually added project to dashboard is removed after re-opening workspace or re-opening IDE
3 participants