Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle O/S windows covering IntelliJ #927

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

turkeylurkey
Copy link
Member

@turkeylurkey turkeylurkey commented Aug 23, 2024

  1. Sometimes an O/S window covers the Liberty tool window button. Need to click it and detect that it opened before continuing. If your click lands on the O/S window then the LTW will not open and an O/S window will open instead. So try clicking again to bring the IntelliJ window to the front and to open the LTW (openAndValidateLibertyToolWindow)
  2. Wait for indexing right after opening the project window so it is done before other tests are run (waitForIndexing moved)
  3. Added waitForIndexing to a few more tests
  4. Indexing can take up to 1 minute before it starts
  5. After adding xml wait a bit before checking the file (needed to fix one failing test in SingleModLibertyLSTestCommon)
  6. Add logging to two methods for future debugging
  7. The Stop button in the debugger can take up to 1 minute to appear in the UI

Fixes #913
Fixes #646

aparnamichael
aparnamichael previously approved these changes Sep 19, 2024
Copy link
Contributor

@aparnamichael aparnamichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@aparnamichael
Copy link
Contributor

@turkeylurkey There is some conflicts in the build.yaml file. Pleas take a look.

@TrevCraw
Copy link
Contributor

Hi @turkeylurkey , the changes here look good, but I am wondering if you think they will still be necessary once we make the changes discussed earlier this week to enable our Liberty Tool Window to only display projects when IntelliJ has completed indexing (i.e. implement #985 for the Liberty Tool Window).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants