Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled developer to input PR number for lsp4ij checkout input #1014

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vaisakhkannan
Copy link
Contributor

@vaisakhkannan vaisakhkannan commented Oct 10, 2024

Fixes #998

Allowing developers to input the PR number for LSP4IJ checkout.

I made some slight changes to the artifact name setup, but there is no effect on previous scenarios. Additionally, I have now enabled specifying the LSP4IJ branch name, tag, PR number, or commit SHA based on the input provided by the developer.

@vaisakhkannan
Copy link
Contributor Author

vaisakhkannan commented Oct 10, 2024

If a developer want to check out LSP4IJ based on a PR number, then developer can check the box labeled “If you checked this, please make sure to enter only the LSP4IJ PR number below” and specify the PR number in the provided text field labeled “Reference/branch for LSP4IJ checkout.” Additionally, developer can specify the tag or branch of the liberty-tools-intellij repository to be used.


NOTE: Make sure to enable the checkbox labeled “Use lsp4ij locally” as well for this case.

Example run

Allow-developer-to-input-PR-number

@TrevCraw , Please suggest the changes in the wordings

@vaisakhkannan vaisakhkannan marked this pull request as draft October 10, 2024 12:08
@vaisakhkannan
Copy link
Contributor Author

Reference workflow runs :

https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276704777 -- Normal push/PR builds
https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276788312 -- Cron Job build

Manually running workflow examples

https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276799815 ( developer entered PR number 411 and LTI version 24.0.9 --> merge commit sha value is not null, so no warning)

https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276805354 ( developer entered PR number 500 and LTI version 24.0.9 --> merge commit sha value is null, so warning is present )

https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276809742 -- LTI main & LSP4IJ main-- ( user entered branch name , main as an input for LSP4IJ checkout )

https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276824366 -- ( user entered merge commit sha as an input for LSP4IJ checkout and LTI 24.0.9 )

https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/11276832458 -- ( user entered LTI 24.0.9 and LSP4IJ main as an input for LSP4IJ checkout )

@vaisakhkannan vaisakhkannan marked this pull request as ready for review October 11, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow developer to input PR number for lsp4ij checkout input
1 participant