Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc page about the CDI Extension SPI #7525

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

benjamin-confino
Copy link
Member

This creates a simple page that goes through implementing CDIExtensionMetadata, it links to a pre-existing blogpost to give a step by step guide to creating a user feature that uses CDIExtensionMetadata

Copy link
Member

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @benjamin-confino

@dmuelle dmuelle changed the base branch from vNext to draft September 5, 2024 13:02
@dmuelle
Copy link
Member

dmuelle commented Sep 5, 2024

Hi @benjamin-confino - I changed the base to draft since all OL content must go through draft and staging before targeting vNext. Would you also open an issue in the doc repo to track the work and reviews for this doc? Please include a recommendation of where in the navigation it should go (probably Context and Dependency Injection section?). I think we should also look at migrating your blog post for developing a user feature to the documentation.

For details about the OL topic writing/publishing process, see Publishing a new topic in the readme. Thanks!

@benjamin-confino
Copy link
Member Author

@dmuelle I've opened the issue as requested, and you are correct to assume this goes under Context and Dependency Injection

@@ -37,6 +37,7 @@
* xref:cdi-beans.adoc[Context and Dependency Injection]
** xref:jaxrs-integration-cdi.adoc[RESTful Web Services integration with CDI]
** https://openliberty.io/guides/cdi-intro.html[Guide: Injecting dependencies into microservices]
** xref:cdi-extension-user-feature.adoc[Creating a CDI Extension inside a User Feature]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid branch conflicts between draft-staging-production, we only update the nav file from a dedicated branch:

https://github.com/OpenLiberty/docs?tab=readme-ov-file#editing-the-docs-navigation

I went ahead and added this entry from the draft-nav branch in #7532

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I thought "They can work with you to determine the best section of the navigation for your topic and to update the nav.adoc file." meant it went into this branch. I've pulled that out of the PR

Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmuelle dmuelle merged commit a32a2cd into OpenLiberty:draft Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants