avoid warning about a self-provided default value in provider config

Signed-off-by: Hans Zandbelt <[email protected]>

ChangeLog

@@ -1,3 +1,6 @@
+03/11/2024
+- avoid warning about setting a self-provided default value in the provider config
+
 03/07/2024
 - OIDCProviderSignedJwksUri: accept verification key set formatted as either JWK or JWKS
   see #1191; thanks @psteniusubi

src/metadata.c

@@ -1090,9 +1090,12 @@ void oidc_metadata_get_valid_int(request_rec *r, const json_t *json, const char
 	oidc_json_object_get_int(json, key, &v, default_int_value);
 	const char *rv = valid_int_function(r->pool, v);
 	if (rv != NULL) {
-		oidc_warn(r, "integer value %d for key \"%s\" is invalid: %s; using default: %d", v, key, rv,
-			  default_int_value);
-		v = default_int_value;
+		// assume the provided default is valid, i.e. "unset" -1, so nothing to warn about
+		if (v != default_int_value) {
+			oidc_warn(r, "integer value %d for key \"%s\" is invalid: %s; using default: %d", v, key, rv,
+				  default_int_value);
+			v = default_int_value;
+		}
 	}
 	*int_value = v;
 }
@@ -1110,7 +1113,7 @@ static void oidc_metadata_get_jwks(request_rec *r, json_t *json, apr_array_heade
 
 	if (!json_is_array(keys)) {
 		oidc_error(r, "trying to parse a list of JWKs but the value for key \"%s\" is not a JSON array",
-				OIDC_JOSE_JWKS_KEYS_STR);
+			   OIDC_JOSE_JWKS_KEYS_STR);
 		return;
 	}