cache file backend fix: delete the correct file upon logout

closes #955; thanks @damisanet Signed-off-by: Hans Zandbelt <[email protected]>
OpenIDC · Nov 13, 2022 · 6565f4c · 6565f4c
1 parent 7673877
commit 6565f4c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -2,6 +2,7 @@
 - switch to using apr_generate_random_bytes instead of apr_uuid_get to generate session identifiers
   so there's no longer a (rather implicit) dependency on a libapr that is compiled againt libuuid
   on Linux platforms; see #431, #603 and #694; thanks @amitnarang28
+- cache file backend fix: delete the correct file upon logout; closes #955; thanks @damisanet
 - bump to 2.4.12.1rc5
 
 11/08/2022

diff --git a/src/cache/file.c b/src/cache/file.c
@@ -392,7 +392,7 @@ static apr_byte_t oidc_cache_file_set(request_rec *r, const char *section, const
 
 	/* just remove cache file if value is NULL */
 	if (value == NULL) {
-		if ((rc = apr_file_remove(path, r->pool)) != APR_SUCCESS) {
+		if ((rc = apr_file_remove(target, r->pool)) != APR_SUCCESS) {
 			oidc_error(r, "could not delete cache file \"%s\" (%s)", path, apr_strerror(rc, s_err, sizeof(s_err)));
 		}
 		return TRUE;