fix OIDCPassClaimsAs environment bug introduced in 2.4.15.4

see #1196; thanks @HolgerHees Signed-off-by: Hans Zandbelt <[email protected]>
OpenIDC · Mar 13, 2024 · 595681c · 595681c
1 parent 3bb1e7c
commit 595681c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -1,6 +1,7 @@
 03/13/2024
 - fix compilation without libhiredis; closes #1195 ; thanks @HolgerHees
   conditionally define oidc_set_redis_connect_timeout
+- fix `OIDCPassClaimsAs environment` bug introduced in 2.4.15.4; see #1196; thanks @HolgerHees
 
 03/12/2024
 - release 2.4.15.4

diff --git a/src/mod_auth_openidc.c b/src/mod_auth_openidc.c
@@ -551,7 +551,7 @@ static apr_byte_t oidc_set_app_claims(request_rec *r, const oidc_cfg *const cfg,
 	apr_byte_t pass_envvars = oidc_cfg_dir_pass_info_in_envvars(r);
 
 	// optimize performance when `OIDCPassClaimsAs none` is set
-	if ((pass_headers == FALSE) && (pass_headers == FALSE))
+	if ((pass_headers == FALSE) && (pass_envvars == FALSE))
 		return TRUE;
 
 	/* decode the string-encoded attributes in to a JSON structure */