fix child initialization routines using multiple vhosts; closes #1208

this fixes possible segmentation faults when using Redis and Metrics settings in vhosts; thanks @studersi Signed-off-by: Hans Zandbelt <[email protected]>
OpenIDC · Sep 6, 2024 · 16d844f · 16d844f
1 parent db29d31
commit 16d844f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -1,5 +1,7 @@
 09/06/2024
 - allow overriding globally set OIDCCacheType back to shm in vhosts
+- correct typo in child initialization routines when using multiple vhosts; closes @1208; thanks @studersi
+  this fixes possible segmentation faults when using Redis and Metrics settings in vhosts
 
 09/05/2024
 - fix OIDCCacheShmMax min/max settings; see #1260; thanks @bbartke

diff --git a/src/mod_auth_openidc.c b/src/mod_auth_openidc.c
@@ -2118,7 +2118,7 @@ static void oidc_child_init(apr_pool_t *p, server_rec *s) {
 	server_rec *sp = s;
 	while (sp != NULL) {
 		oidc_cfg_t *cfg = (oidc_cfg_t *)ap_get_module_config(sp->module_config, &auth_openidc_module);
-		oidc_cfg_child_init(p, cfg, s);
+		oidc_cfg_child_init(p, cfg, sp);
 		sp = sp->next;
 	}
 	apr_pool_cleanup_register(p, s, oidc_cleanup_child, apr_pool_cleanup_null);