Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workflow activation limiter on index toggle #2777

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

jyeshe
Copy link
Member

@jyeshe jyeshe commented Dec 12, 2024

Description

This PR fixes the workflow usage limiting when using the a toggle on the workflows index/list.

It also propagates the limit error change/assigns so that the create button is disabled without a page refresh.

Closes #2778

Validation steps

  1. On the billing app using this branch, go to the workflows list of a free subscription
  2. Deactivate the existing workflow(s)
  3. Create a new one and activate it
  4. Try to activate another one on the workflows list

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (c9cad42) to head (914c3e1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2777      +/-   ##
==========================================
- Coverage   91.25%   91.25%   -0.01%     
==========================================
  Files         335      335              
  Lines       11933    11932       -1     
==========================================
- Hits        10890    10889       -1     
  Misses       1043     1043              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jyeshe jyeshe force-pushed the fix-workflow-usage-limiting branch from 26a79d3 to 200a993 Compare December 12, 2024 10:55
@jyeshe jyeshe force-pushed the fix-workflow-usage-limiting branch from 200a993 to 0be6496 Compare December 12, 2024 11:46
@jyeshe jyeshe closed this Dec 12, 2024
@jyeshe jyeshe deleted the fix-workflow-usage-limiting branch December 12, 2024 14:57
@jyeshe jyeshe reopened this Dec 12, 2024
@jyeshe jyeshe force-pushed the fix-workflow-usage-limiting branch from 52ae4bd to 72233fe Compare December 12, 2024 15:19
@jyeshe jyeshe force-pushed the fix-workflow-usage-limiting branch 2 times, most recently from 669fafb to ac86c11 Compare December 12, 2024 16:54
@jyeshe jyeshe force-pushed the fix-workflow-usage-limiting branch from ac86c11 to 5a7b56a Compare December 12, 2024 16:57
@jyeshe jyeshe requested a review from stuartc December 12, 2024 17:14
@jyeshe jyeshe self-assigned this Dec 12, 2024
@jyeshe jyeshe marked this pull request as ready for review December 12, 2024 17:16
Copy link
Member

@stuartc stuartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGLELOG

@jyeshe jyeshe requested a review from elias-ba December 13, 2024 15:17
Copy link
Contributor

@elias-ba elias-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @jyeshe 👏🏽, thanks

@jyeshe jyeshe merged commit e8eeed2 into main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Workflows index allows activating more workflows than the limit
3 participants