-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ms graph adaptor docs #515
Conversation
@aleksa-krolls I defer to @christad92 as he completed the configuration in Azure. I would be happy to review any Docs on setting up the credential in OpenFn. |
@ritazagoni @christad92 do we have any draft docs on setting up the msgraph oauth credential somewhere? if not, then @daissatou2 can you maybe pls draft that in a Google doc for Ayodele to review? We can then later add to the Adaptor overview page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christad92 @ritazagoni These docs need work. Major comments:
- No link to the main Microsoft Graph API docs: https://learn.microsoft.com/en-us/graph/use-the-api
- We need a better introduction and context-setting in this doc. You dive right into how to configure Oauth clients, without explaining why (e.g.,
To connect with Microsoft Graph API, Oauth is the accepted authentication method. Follow these instructions to set up Oauth access via OpenFn.
) - Please address my open comments in the Documentation gdoc - I still have some questions about why some of this info is in here/what is its purpose. For example, the
Scopes
list is really random and there is no explanation on what it's for
Yes, there is a draft for this on the documentation doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ritazagoni great work here.
But I think there is some work to be done here.
- For the MSgraph overview we need to follow the new template as defined here.
- For the Authorization/Authentication section, I think we need to create a page for Administering Generic OAuth clients and credentials which will be referenced for adaptors that require OAuth e.g. Salesforce, Google, etc.
- The last part of this is the Managing MS Graph Generic OAuth Client on OpenFn which introduces the topic of creating MS Graph Apps.
I will take a stab at this next week -- creating these 3-4 pages and will share them for review by Friday.
cc: @aleksa-krolls
@ritazagoni can you close this? I am making a new PR that covers the overview without any extra stuff. |
Abandoned - replaced by another clean PR |
No description provided.