Skip to content

Commit

Permalink
Remove phantomjs and use goutte instead for webtest
Browse files Browse the repository at this point in the history
  • Loading branch information
Eric Pinxteren committed Dec 21, 2017
1 parent 04b0db0 commit cec30ad
Show file tree
Hide file tree
Showing 15 changed files with 379 additions and 149 deletions.
2 changes: 1 addition & 1 deletion .rmt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ _default:
working-copy-check: ~
display-last-changes: ~
composer-stability-check: ~
tests-check: {command: composer test-ci}
tests-check: {command: composer test}

# GENERAL CONFIG
# Apply to all branches except the one from the 'branch-specific' section
Expand Down
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ before_script:

script:
# Test if the website is actually running
- phantomjs --config=./phantomjs.json < /dev/null &
- composer test-ci
- composer test

after_script:
- cat $TRAVIS_BUILD_DIR/error.log
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ Tests and metrics
To run all required test you can run the following commands from the dev env:

```bash
./bin/bootstrap_phantomjs.sh
composer test
```

Expand Down
18 changes: 15 additions & 3 deletions behat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@ default:
Behat\MinkExtension:
base_url: https://gssp.stepup.example.com
default_session: 'symfony2'
goutte:
guzzle_parameters:
curl.CURLOPT_SSL_VERIFYPEER: false
curl.CURLOPT_CERTINFO: false
ssl.certificate_authority: false
verify: false
sessions:
symfony2:
symfony2: ~
selenium2:
wd_host: "http://127.0.0.1:8646/wd/hub"
capabilities: { "browser": "firefox", "version": "14"}

Behatch\Extension: ~
suites:
app_bundle:
Expand All @@ -23,4 +27,12 @@ default:
- Behat\MinkExtension\Context\MinkContext
- behatch:context:xml
bundle: 'AppBundle'
sp_bundle:
type: symfony_bundle
contexts:
- AppBundle\Features\Context\WebContext
- AppBundle\Features\Context\ErrorReportContext
- Behat\MinkExtension\Context\MinkContext
- behatch:context:xml
bundle: 'SpBundle'

4 changes: 0 additions & 4 deletions bin/bootstrap_phantomjs.sh

This file was deleted.

Binary file removed bin/phantomjs
Binary file not shown.
11 changes: 1 addition & 10 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"behat/behat": "^3.4",
"behat/mink-browserkit-driver": "^1.3",
"behat/mink-extension": "^2.2",
"behat/mink-selenium2-driver": "^1.3",
"behat/mink-goutte-driver": "^1.2",
"behat/symfony2-extension": "^2.1",
"behatch/contexts": "^2.7",
"jakub-onderka/php-parallel-lint": "^0.9.2",
Expand All @@ -69,14 +69,6 @@
"@security-tests"
],

"test-ci": [
"@lint",
"@static-analysis",
"@phpunit",
"@behat-ci",
"@security-tests"
],

"lint": ["@lint-php", "@lint-yml", "@lint-composer"],
"lint-php": "vendor/bin/parallel-lint app src",
"lint-yml": "bin/console lint:yaml app/config",
Expand All @@ -93,7 +85,6 @@

"phpunit": "vendor/bin/phpunit tests",
"behat": ["vendor/bin/behat --config behat.yml"],
"behat-ci": ["vendor/bin/behat --config behat.yml --tags '~@javascript'"],

"security-tests": "vendor/bin/security-checker security:check --end-point=http://security.sensiolabs.org/check_lock",

Expand Down
Loading

0 comments on commit cec30ad

Please sign in to comment.