Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OC-23197 Do not offer browser autocomplete options for RFC fields #209

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OC-23197 Do not offer browser autocomplete options for RFC fields #209

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1c82d4
OC-23197 Do not offer browser autocomplete options for RFC fields
gushil Jul 30, 2024
c0c515b
Revert "OC-23197 Do not offer browser autocomplete options for RFC fi…
gushil Aug 6, 2024
e84e16c
Set autocomplete off to all widget elements that can have autocomplet…
gushil Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/enketo-core/src/js/widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,19 @@ class Widget {
this.question = element.closest('.question');
this._props = this._getProps();

// Based on https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
// set autocomplete off for all elements that can have autocomplete attribute
if (
(this.element.nodeName.toLowerCase() === 'input' &&
['text', 'number'].includes(
this.element.getAttribute('type')
)) ||
this.element.nodeName.toLowerCase() === 'textarea' ||
this.element.nodeName.toLowerCase() === 'select'
) {
this.element.setAttribute('autocomplete', 'off');
}

// Some widgets (e.g. ImageMap) initialize asynchronously and init returns a promise.
return this._init() || this;
}
Expand Down
Loading