401 response ton /manifest request not returning error code for API call to Enketo

[pbowen-oc]

When we call a PDF endpoint to create a PDF of a form, we are sometimes not able to handle the /manifest call from Enketo and returning 401 for it. In these cases, the form cannot be returned as a PDF but we are not getting an error code response to indicate this. The expectation is that the call to Enketo will return an error code if the form cannot be returned as a PDF.

[MartijnR]

readonly view: http://localhost:8005/view/fs/i/bc779317d111a78dba079c30335325b2?ecid=1

PDF:

curl --user enketorules: -d "server_url=http://localhost:3000&form_id=slash&ecid=1"  http://localhost:8005/oc/api/v1/survey/view/pdf > ~/Downloads/pdf1.pdf

PDF URL used internally by the PDF API endpoint: http://localhost:8005/view/fs/bc779317d111a78dba079c30335325b2?ecid=1&print=true

In Centro's form.js, let manifest controller return a 401:

.then( manifest => {
                //res.send( manifest.toString() );
                res.status(401);
                res.end()
            } )

[MartijnR]

Notes to self:

Succeeded in inspecting requests and finding a 401 response. Still figuring out how to properly reject/throw an error so that it can be caught. I have a feeling that the code in headless.js also is not catching errors (hence the old comments 'unable to reach) in that code.

• create fix (since we've deviated already in pdf.js and still need to offer that to enketo/enketo-express)
• create PR for enketo/enketo-express with all pdf.js changes (after testing by OC?) - Fix/various pdf fixes enketo/enketo-express#577

[MartijnR]

Please leave open for last bullet point (done)

[MartijnR]

• See ODK PR feedback and improve