This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
fixed: if pdf page encounters a 401 response this will be API respons… #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobotoolbox#688 fixed: a headless chrome instance will now be kept alive at all times so pdf responses should be quicker
kkrumlian
approved these changes
Jul 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e, OpenClinica/enketo-oc#34
fixed: a headless chrome instance will now be kept alive at all times so pdf responses should be quicker
OpenClinica/enketo-oc#34
Also noticed an error in the code that leads to Enketo to still open a new instance of headless Chrome for each PDF request. That was fixed. We may see a big improvement in API response time for PDF endpoints.