Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

OC-21992 HTML code for double quotes appear in field history when text field is updated #732

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

theywa
Copy link

@theywa theywa commented Jan 3, 2024

Merging latest master into 6.2.2.oc
Copy link
Member

@MartijnR MartijnR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling there are more bugs to be discovered like this one. They are all caused by #722. However, I don't actually understand how that PR caused them (even when removing the quote replacements in _encodeHtml the bug still persists!

I think this solution is fine. However, if another bug like this pops up we'll need to start adding tests for all of them, and take a more holistic view of rendering text in that widget.

widget/discrepancy-note/dn-widget.js Show resolved Hide resolved
@MartijnR
Copy link
Member

MartijnR commented Jan 5, 2024

I restarted the CI testing because it may have been a fluke that it failed.

Copy link
Member

@MartijnR MartijnR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theywa
Copy link
Author

theywa commented Jan 9, 2024

Oops, looks like some eslint errors: https://github.com/OpenClinica/enketo-express-oc/actions/runs/7397885252/job/20209279340?pr=732#step:8:1744

yes, I run eslint: fix now for fix but it looks like the npm test still failed

@MartijnR MartijnR merged commit bc7dc55 into OpenClinica:master Jan 10, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants