-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compartiments #68
Open
Lanseeg
wants to merge
39
commits into
OpenClassrooms-Student-Center:master
Choose a base branch
from
Lanseeg:compartiments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Compartiments #68
Lanseeg
wants to merge
39
commits into
OpenClassrooms-Student-Center:master
from
Lanseeg:compartiments
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod over promises. Creation of function displayGallery with article, img & figcaption. Every block commented. Station: peranTravel
…ateFilters, which creates a button for each category, and adds event listener. Adding as well a Tous or All button to show all items. Filter gallery displays every article card of the selected button
…nd index.html in order to inject html through js
…ught script.js with createElement, to match the other functions.
…he filter buttons according to the figma design
…h de figma design. Login page to CSS-amend.
…orage. Added a small loading indicator to show that a request is being sent, for low internet connections
… CSS amended to display a message that confirms disconnection
…o-pen icon display. Menu nav links now points toward the appropriate section
…to match figma design. This part could later be pushed from the js instead of being on the main html page
…ing edit button and hiding filters. If attempt to go to login.html when connected, redirection to index.html
…by ticking x or outside the box. Ready for content insertion.
…d of having them in the base HTML. Comments show location on HTML files.
… Effect applied on close box. Border added on the bottom of the admin-gallery. style.css amended to match figma template
… amended to match figma design. font-awesome icon wasn't available for free, used a free version instead and applied a hover effect for better navigation
…ad pictures screen. did a little bit of CSS but needs reworks for that part. Had to fix the fadein fadeout effect. Added a font-awesome icon
…ion thr. script.js amended for better responsive
…artementalized js files
…ckground when selected
… gallery from API
…odal content with innerHTML
…s to fit the Figma design
… from the modal. Made the modal.js a module. Updated index.html accordingly
…n the login and logout messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.