Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] chosen value still displayed on click away (#8983) #9476

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Dec 30, 2024

Proposed changes

  • object value instead of an array on field
  • fix on status, author and creator

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.34%. Comparing base (e4728c3) to head (adb06fd).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9476   +/-   ##
=======================================
  Coverage   65.34%   65.34%           
=======================================
  Files         624      624           
  Lines       59697    59697           
  Branches     6687     6687           
=======================================
  Hits        39011    39011           
  Misses      20686    20686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ValentinBouzinFiligran ValentinBouzinFiligran merged commit be3b778 into master Jan 2, 2025
6 checks passed
@ValentinBouzinFiligran ValentinBouzinFiligran deleted the issue/8983 branch January 2, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bulk update] The chosen "values" disappear when you click outside the field
2 participants