[backend] Domain Name Creation Error (#9457) #9475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9475 +/- ##
==========================================
- Coverage 65.34% 65.33% -0.01%
==========================================
Files 624 624
Lines 59697 59697
Branches 6687 6686 -1
==========================================
- Hits 39011 39006 -5
- Misses 20686 20691 +5 ☔ View full report in Codecov by Sentry. |
aHenryJard
reviewed
Jan 2, 2025
aHenryJard
reviewed
Jan 3, 2025
|
|
||
| it('Domain-name regex parsing should be perfomant', async () => { | ||
| const startDate = Date.now(); | ||
| // eslint-disable-next-line no-plusplus |
There was a problem hiding this comment.
you can eventually use i+=1 to avoid this eslint disable, but it's not a blocker for me.
aHenryJard
reviewed
Jan 3, 2025
| }); | ||
|
|
||
| it('should not match a valid domain pattern', () => { | ||
| expect('invalid_domain.12_3').not.toMatch(domainChecker); | ||
| expect('invalid_domain').not.toMatch(domainChecker); |
There was a problem hiding this comment.
we don't need at least one '.' in the domain name ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues