Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix loading issue when exporting as an image or PDF in the opposite theme mode (#9231 #9011) #9474

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Dec 30, 2024

Proposed changes

  • Always exporting to false when it's finished

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 30, 2024
@CelineSebe CelineSebe changed the title [frontend] Fix loading issue when exporting as an image or PDF in the opposite theme mode [frontend] Fix loading issue when exporting as an image or PDF in the opposite theme mode (#9231 #9011) Dec 30, 2024
@CelineSebe CelineSebe self-assigned this Dec 30, 2024
@CelineSebe CelineSebe marked this pull request as ready for review December 30, 2024 10:59
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.34%. Comparing base (e4728c3) to head (e70b409).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9474      +/-   ##
==========================================
- Coverage   65.34%   65.34%   -0.01%     
==========================================
  Files         624      624              
  Lines       59697    59697              
  Branches     6687     6685       -2     
==========================================
- Hits        39011    39010       -1     
- Misses      20686    20687       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact self-requested a review January 2, 2025 15:22
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested for workspaces export and TTP matrix exports

@CelineSebe CelineSebe merged commit 3cc1e83 into master Jan 3, 2025
6 checks passed
@CelineSebe CelineSebe deleted the issue/9231 branch January 3, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
3 participants