Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Data tables for playbooks #9470

Merged
merged 5 commits into from
Jan 3, 2025
Merged

[frontend] Data tables for playbooks #9470

merged 5 commits into from
Jan 3, 2025

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Dec 27, 2024

Proposed changes

  • Implement data tables for playbooks
  • When creating a playbook, we are redirected automatically to the e dition page of the playbook

Related issues

to align playbook behavior with custom dashboards and future fintel templates (in particular, the 3 dots at the end of a playbook line)

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Dec 27, 2024
@Archidoit Archidoit self-assigned this Dec 27, 2024
@romain-filigran
Copy link
Member

When creating a playbook, we are redirected automatically to the e dition page of the playbook
Perhaps we should do the same with the following to be consistent ??? @richard-julien ??

  • dashboard
  • investigation

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.20%. Comparing base (3965ff7) to head (f4b7229).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9470      +/-   ##
==========================================
+ Coverage   65.19%   65.20%   +0.01%     
==========================================
  Files         628      628              
  Lines       59961    59961              
  Branches     6685     6691       +6     
==========================================
+ Hits        39090    39096       +6     
+ Misses      20871    20865       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frapuks frapuks self-requested a review January 3, 2025 07:21
Copy link
Member

@frapuks frapuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@Archidoit Archidoit force-pushed the issue/8336-playbook branch from 8997d8e to f4b7229 Compare January 3, 2025 11:06
@Archidoit Archidoit merged commit 8a4f9ca into master Jan 3, 2025
9 checks passed
@Archidoit Archidoit deleted the issue/8336-playbook branch January 3, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants