Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Improve the Apply buttons in Suggestions (#9291) #9465

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Dec 26, 2024

Proposed changes

  • Change color & add tooltip

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@CelineSebe CelineSebe changed the title [frontend] Change color button in Suggestions [frontend] Change color button in Suggestions (#9291) Dec 26, 2024
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 26, 2024
@CelineSebe CelineSebe linked an issue Dec 26, 2024 that may be closed by this pull request
@CelineSebe CelineSebe self-assigned this Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.34%. Comparing base (4af08e1) to head (4191766).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9465      +/-   ##
==========================================
+ Coverage   65.33%   65.34%   +0.01%     
==========================================
  Files         624      624              
  Lines       59696    59698       +2     
  Branches     6684     6688       +4     
==========================================
+ Hits        39004    39012       +8     
+ Misses      20692    20686       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CelineSebe CelineSebe marked this pull request as ready for review December 30, 2024 08:34
@CelineSebe CelineSebe changed the title [frontend] Change color button in Suggestions (#9291) [frontend] Improve the Apply buttons in Suggestions (#9291) Jan 2, 2025
@CelineSebe CelineSebe merged commit 657c24e into master Jan 2, 2025
6 checks passed
@CelineSebe CelineSebe deleted the issue/9291 branch January 2, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons not clear in Suggestions
2 participants