Fix dashboard header UI (under FAB replacement FF) #9464
Conversation
| @@ -135,6 +134,7 @@ const WorkspaceCreation = ({ paginationOptions, type }) => { | |||
| > | |||
| {t_i18n('Import dashboard')} | |||
| </Button> | |||
| <CreateEntityControlledDial entityType='Dashboard' {...props} /> | |||
There was a problem hiding this comment.
we keep the same order everywhere : from left to right = tertiary > secondary > primary
| <Security | ||
| needs={[EXPLORE_EXUPDATE, INVESTIGATION_INUPDATE]} | ||
| hasAccess={canEdit} | ||
| placeholder={ |
There was a problem hiding this comment.
Security placeholder was the same as the child component, so either the Security is irrelevant or we need to remove the placeholder.
| /> | ||
| {isFABReplaced && ( | ||
| <div style={{ marginTop: 8 }}> | ||
| <DashboardTimeFilters |
There was a problem hiding this comment.
I refactored the time filters, extracting the code from WorkspaceHeader and using it just here, in the dashboard.
| @@ -1452,15 +1452,15 @@ const WidgetConfig = ({ workspace, widget, onComplete, closeMenu }) => { | |||
| <Button | |||
| variant='outlined' | |||
| disableElevation | |||
| style={{ marginTop: '2.5px', marginLeft: '4px' }} | |||
| sx={{ marginLeft: 1 }} | |||
There was a problem hiding this comment.
quick styling fix on my way
| @@ -103,6 +104,9 @@ const PublicDashboards = () => { | |||
| const { t_i18n } = useFormatter(); | |||
| const { isFeatureEnable } = useHelper(); | |||
|
|
|||
| const { setTitle } = useConnectedDocumentModifier(); | |||
| setTitle(t_i18n('Public dashboards')); | |||
There was a problem hiding this comment.
unrelated fix on the way : tab title was Dashboard_public
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.5.0 #9464 +/- ##
==============================================
Coverage 65.38% 65.39%
==============================================
Files 626 626
Lines 60127 60127
Branches 6767 6768 +1
==============================================
+ Hits 39313 39318 +5
+ Misses 20814 20809 -5 ☔ View full report in Codecov by Sentry. |
Proposed changes
Under FAB_REPLACMEENT feature flag, the import/create buttons are moved to the header bar, which is already crowded with buttons.
I suggest to move the time filters under the header, so that the header displays correctly when the screen size is >= 1400px wide.