[backend] fix file access restriction to also target trash index (#9424) #9455
Conversation
github-actions
bot
added
the
filigran team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9455 +/- ##
==========================================
- Coverage 65.34% 65.33% -0.01%
==========================================
Files 624 624
Lines 59696 59696
Branches 6685 6689 +4
==========================================
- Hits 39009 39005 -4
- Misses 20687 20691 +4 ☔ View full report in Codecov by Sentry. |
| entity_type="Malware", entity_id=self.entity_id, mode="full" | ||
| entity_type=self.entity_type, entity_id=self.entity_id, mode="full" |
There was a problem hiding this comment.
This change is unrelated to the fix. It's just to make this script more usable in other conditions.
I have updated it during my dev, but I thought it was still something good to keep.
| opencti_api_client = OpenCTIApiClient(self.api_url, self.api_token) | ||
|
|
||
| # Upload the given file to the entity | ||
| opencti_api_client.stix_domain_object.add_file( |
There was a problem hiding this comment.
new utility for our tests, to upload a file to an entity
|
I don't get why the file attached to the report is deleted/sent to the trash when the report is deleted. It should simply be marked as removed with the EDIT: after testing, I understand your change better now. I thought the file was sent to the trash as well, but that's not the case, your change is to make it possible to load the entity related to the file. |
Proposed changes
When using
internalLoadByIdto do a file access check, target also the trash index and not only the read indices.Related issues
Checklist
Further comments