Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] logout URL missing for Auth0 strategy (#9466) #9467

Merged
merged 5 commits into from
Jan 3, 2025
Merged

[backend] logout URL missing for Auth0 strategy (#9466) #9467

merged 5 commits into from
Jan 3, 2025

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Dec 26, 2024 •
edited
Loading

Proposed changes

  • add remote option
  • add logout function implementation

Refactor:

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Dec 26, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 65.29%. Comparing base (aa720ca) to head (1144d7b).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...i-platform/opencti-graphql/src/config/providers.js 0.00% 43 Missing ⚠️
...-platform/opencti-graphql/src/http/httpPlatform.js 0.00% 19 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9467      +/-   ##
==========================================
- Coverage   65.34%   65.29%   -0.05%     
==========================================
  Files         624      624              
  Lines       59696    59736      +40     
  Branches     6687     6687              
==========================================
- Hits        39010    39007       -3     
- Misses      20686    20729      +43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard changed the title logout_remote option missing on some auth strategy [backend] logout URL missing for Auth0 strategy (#9466) Dec 27, 2024
@aHenryJard aHenryJard marked this pull request as ready for review December 27, 2024 10:34
@aHenryJard aHenryJard mentioned this pull request Dec 27, 2024
Merged
@marieflorescontact marieflorescontact self-requested a review January 3, 2025 07:29
marieflorescontact
marieflorescontact approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ok 👌

@aHenryJard aHenryJard merged commit d16405e into master Jan 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marieflorescontact marieflorescontact marieflorescontact approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logout remote option missing on Auth0 strategy
2 participants
@aHenryJard @marieflorescontact