Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons not clear in Suggestions #9291

Closed
Archidoit opened this issue Dec 11, 2024 · 1 comment · Fixed by #9465
Closed

Buttons not clear in Suggestions #9291

Archidoit opened this issue Dec 11, 2024 · 1 comment · Fixed by #9465
Assignees
@CelineSebe
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) ui for scope limited to UI change
Milestone
Release 6.4.6

Comments

@Archidoit
Copy link
Member

Description

The buttons and color are not clear in the Suggestion tab

Reproducible Steps

  • In a container, go in the Knowledge tab

  • Open the suggestions
    Image

  • Fill the form and eventually apply the suggestions

  • If the suggestions has been applied the button is green, if not it is also green (but a different green). --> it's not very clear
    Image

Expected behavior

Choose two different color for the button
Add a tooltip in the button describing the behavior
@Archidoit Archidoit added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Dec 11, 2024
@Archidoit Archidoit changed the title Colors not clear in Suggestions Buttons not clear in Suggestions Dec 11, 2024
@nino-filigran
Copy link

I agree, we should opt for the green in suggestion (the lighter one)

@nino-filigran nino-filigran added ui for scope limited to UI change and removed needs triage use to identify issue needing triage from Filigran Product team labels Dec 13, 2024
@romain-filigran romain-filigran added this to the Bugs backlog milestone Dec 17, 2024
@CelineSebe CelineSebe self-assigned this Dec 26, 2024
@CelineSebe CelineSebe mentioned this issue Dec 26, 2024
Merged
5 tasks
@CelineSebe CelineSebe linked a pull request Dec 26, 2024 that will close this issue
[frontend] Improve the Apply buttons in Suggestions (#9291) #9465
Merged
5 tasks
CelineSebe added a commit that referenced this issue Jan 2, 2025
@CelineSebe
[frontend] Improve "apply buttons" in Suggestions (#9291)
657c24e
@romain-filigran romain-filigran added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CelineSebe CelineSebe

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) ui for scope limited to UI change
Projects
None yet
Milestone
Release 6.4.6
Development

Successfully merging a pull request may close this issue.

[frontend] Improve the Apply buttons in Suggestions (#9291) OpenCTI-Platform/opencti
4 participants
@Archidoit @CelineSebe @nino-filigran @romain-filigran