-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Maven #27
Migrate to Maven #27
Conversation
Hi Šarūnas Navickas Thanks for this suggestion! This appears to be related to what Adam Leskis has been working on with making a Docker image for the build: It would be helpful if you and Adam (also Dave Howcroft?) could comment on whether it would make sense to incorporate both of these suggestions or just one or the other, and if both, whether there are any conflicts to resolve or synergies to pursue. Mike |
The migration to use maven is sensible in any case, and the docker build branch could easily be rebased to incorporate this after its merged in. |
Yes, I think these two are independant. If anything, this should make Docker image creation easier since maven is quite easy to setup and dependencies are downloaded instead of copied manually |
My initial impression is that this build process simplifies the work that @lpmi-13 did to create the Docker image, so I also agree it would make sense to incorporate this PR before doing that one. |
Ok, thanks all, went ahead with the merge! |
just a note that we may also want to update the installation documentation to incorporate the new maven process. |
It would be great if someone who is familiar with maven could add this!
…On Thu, Jul 18, 2019 at 12:12 PM Adam Leskis ***@***.***> wrote:
just a note that we may also want to update the installation documentation
to incorporate the new maven process.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#27?email_source=notifications&email_token=AA6G7TNRTXVFKVNJPGHLIUDQACJAJA5CNFSM4ICJQPOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2I72UI#issuecomment-512884049>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA6G7TP6XKVLDA6J5YIUDZTQACJAJANCNFSM4ICJQPOA>
.
|
mvn package
will now:Old ant
build.xml
is still there, because there are parts like site and documentation which are not yet covered by maven