Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Maven #27

Merged
merged 10 commits into from
Jul 16, 2019
Merged

Migrate to Maven #27

merged 10 commits into from
Jul 16, 2019

Conversation

zaibacu
Copy link
Contributor

@zaibacu zaibacu commented Jul 12, 2019

mvn package will now:

  • Download all of the required libraries (no more copy/pasting in order to build it)
  • Generates required stuff
  • Compiles
  • Packages into jar

Old ant build.xml is still there, because there are parts like site and documentation which are not yet covered by maven

@mwhite14850
Copy link
Member

Hi Šarūnas Navickas

Thanks for this suggestion! This appears to be related to what Adam Leskis has been working on with making a Docker image for the build:

#23

It would be helpful if you and Adam (also Dave Howcroft?) could comment on whether it would make sense to incorporate both of these suggestions or just one or the other, and if both, whether there are any conflicts to resolve or synergies to pursue.

Mike

@lpmi-13
Copy link

lpmi-13 commented Jul 15, 2019

The migration to use maven is sensible in any case, and the docker build branch could easily be rebased to incorporate this after its merged in.

@zaibacu
Copy link
Contributor Author

zaibacu commented Jul 16, 2019

Yes, I think these two are independant. If anything, this should make Docker image creation easier since maven is quite easy to setup and dependencies are downloaded instead of copied manually

@dmhowcroft
Copy link
Contributor

My initial impression is that this build process simplifies the work that @lpmi-13 did to create the Docker image, so I also agree it would make sense to incorporate this PR before doing that one.

@mwhite14850 mwhite14850 merged commit 9968e81 into OpenCCG:master Jul 16, 2019
@mwhite14850
Copy link
Member

Ok, thanks all, went ahead with the merge!

@lpmi-13
Copy link

lpmi-13 commented Jul 18, 2019

just a note that we may also want to update the installation documentation to incorporate the new maven process.

@mwhite14850
Copy link
Member

mwhite14850 commented Jul 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants