Add included services #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Symbitic, thanks a lot for these contributions! In order to help me speed up the review, testing and merging of your features, could you split the changes of this MR into smaller MRs that I can individually try out? Top of my mind, the separation I would make is:
I hope this can help make the addition of features much faster and easier to test :D |
|
Sure. I'll extract included services and power state from this and leave it as just capabilities. |
|
I stand corrected: I leave this PR as included services and extracted capabilities and power state to separate PRs. |
Symbitic
changed the title
kdewald
force-pushed
the
main
branch
3 times, most recently
from
9dfb30e to
a655d39
Compare
|
@kdewald any updates? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several characteristic capabilities that were missing.
It also adds
included_services(), but it returns it as an array of UUIDs instead of objects.