Fix a few issues with the C generator (part 7) #20366
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another new warning I've noticed when building our api with the latest version:
This is not actually a regression, the code was always broken but recent changes made the warning show up. This pull request does the following:
valueForm
tochar *
.There are other issues with formData input. I think valueForm should become
char *
for all types, not just bool. But this involves bigger changes, so I might look into it at some later time.