Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart-dio] The referenced name (extras) isn't visible in scope. #20319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndrewDongminYoo
Copy link

@AndrewDongminYoo AndrewDongminYoo commented Dec 13, 2024

This pull request removes incorrect references to the extras property within the Dart-Dio code generator templates. Currently, the generated code attempts to use a non-existent extras field on dio.Options, leading to compilation errors. By removing these references, the generated code will correctly compile against the current dio version.

What was done:

  • Updated the Dart-Dio client code generation templates to no longer output extras references.
  • Verified that generated code compiles and runs without reference errors.
  • Regenerated and tested sample outputs to ensure compatibility.

Why this is needed:

  • Prevents compilation errors due to non-existent fields.
  • Ensures generated Dart-Dio clients are fully compatible with dio's current API.

Issue reference (if any):

  • (If there's an open issue related to this, reference it here. Otherwise, remove this line.)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
./mvnw clean package || exit
./bin/generate-samples.sh ./bin/configs/\*.yaml || exit
./bin/utils/export_docs_generators.sh || exit

(For Windows users, please run the script in Git BASH)
Commit all changed files.

  • Ensure all generated samples match expected outputs to pass CI checks.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@AndrewDongminYoo AndrewDongminYoo changed the title fix: the referenced name (extras) isn't visible in scope [dart-dio] The referenced name (extras) isn't visible in scope. Dec 13, 2024
@AndrewDongminYoo
Copy link
Author

Copy link
Contributor

@ahmednfwela ahmednfwela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @wing328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants