Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted csharp codegen to allow for nullable properties #20299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BryanAldrich
Copy link
Contributor

For value types only unless nullable reference types is enabled.

Edited tests to compensate for the actual data types. They were optional/not-required in the yaml, but came back with non-nullable types.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…pes only unless nullable reference types is enabled).

Edited tests to compensate for the actual data types. They were optional/not-required in the yaml, but came back with non-nullable types.
@BryanAldrich BryanAldrich force-pushed the AllowModelPropertiesToBeNullable branch from 99d050f to b56aa31 Compare December 11, 2024 21:01
@devhl-labs
Copy link
Contributor

Looks good, but embedding the question mark in the data type is something we should try to remove eventually. We can use the nullable property, x-is-value-type, or x-is-nullable-type (true for value or nrt enabled). I've already handled it for generichost.

@BryanAldrich
Copy link
Contributor Author

So, you're saying to add {{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}} in the mustache template on the properties (i copied that from the generichost template). And then remove the java edit?

@devhl-labs
Copy link
Contributor

Yes, that is one way. We could also add a vendor extension to concat the data type and the ? if we like. This is just a suggestion for a future pr though, you can leave this alone if you want.

@BryanAldrich BryanAldrich marked this pull request as ready for review December 16, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants