Fixes #2981 Error when trying to edit a table parameter in simulation #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwmcintosh
commented
Oct 4, 2024
Comment on lines
+151
to
+174
|
|
||
| public class TableParameterPresenter : TableParameterPresenter<ITableFormulaView>, ITableParameterPresenter | ||
| { | ||
| public TableParameterPresenter(ITableFormulaView view, IParameterTask parameterTask, IFormulaFactory formulaFactory, ICloner cloner) : | ||
| base(view, parameterTask, formulaFactory, cloner) | ||
| { | ||
| // default import function disabled when context is not specified | ||
| view.ImportVisible = CanImport; | ||
| } | ||
|
|
||
| protected override DataRepository ImportTablePoints() | ||
| { | ||
| // default import function disabled when context is not specified | ||
| throw new System.NotImplementedException(); | ||
| } | ||
|
|
||
| protected override TableFormula TablePointsToTableFormula(DataRepository importedTablePoints) | ||
| { | ||
| // default import function disabled when context is not specified | ||
| throw new System.NotImplementedException(); | ||
| } | ||
|
|
||
| public override bool CanImport => false; | ||
| } |
There was a problem hiding this comment.
The class went missing as I moved presenters around to get table formula view in MoBi.
This particular presenter did not allow import from Excel
Yuri05
reviewed
Oct 6, 2024
| protected override DataRepository ImportTablePoints() | ||
| { | ||
| // default import function disabled when context is not specified | ||
| throw new System.NotImplementedException(); |
There was a problem hiding this comment.
Yeah, the interface requires these methods, but to satisfy the button for import, however, in this case the button is hidden with the comment that import is not allowed. We could return DataRepos and TableFormula or return null to avoid this ugly sight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2981
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):