Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #387 openeo.connect, reinstate old behavior: no PermissionError on Windows #399

Conversation

JohanKJSchreurs
Copy link
Contributor

@JohanKJSchreurs JohanKJSchreurs commented Mar 16, 2023

Issue #387 Quick fix, reinstate old behavior: no PermissionError on Windows for PrivateJsonFile, log message instead

Fixes #387

Reinstated the old behavior of authenticate_oidc on Windows:
When PrivateJsonFile may be readable by others, log message instead of raising a PermissionError.

There is a follow-up issue here #400, if we still want to find a more secure solution for Windows.
To be decided.

Also, for now I have left in the code that uses oschmod because:

  1. when it does work, then it still adds a bit more security;
  2. we would like to get a solution out quickly, but removing oschmod cleanly takes a bit more work and care.

…indows for PrivateJsonFile, log message instead
@JohanKJSchreurs JohanKJSchreurs changed the title Issue #387 Quick fix, reinstate old behavior: no PermissionError on W… Issue #387 openeo.connect, reinstate old behavior: no PermissionError on Windows Mar 16, 2023
@JohanKJSchreurs JohanKJSchreurs marked this pull request as ready for review March 16, 2023 13:47
@JohanKJSchreurs JohanKJSchreurs linked an issue Mar 17, 2023 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
@soxofaan soxofaan merged commit eab2465 into master Mar 28, 2023
@soxofaan soxofaan deleted the issue387-fix-openeo-connect-error-instead-of-warning-on-windows branch March 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openeo.connect error instead of warning in newer version
2 participants