Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce boss doors side range to prevent voiding out in Forest temple #2331

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Nov 17, 2024

Boss doors in 1.0 have a wider range than what the door textures actually shows. Which can lead to this unfortunate scenario in Forest temple : https://www.twitch.tv/yoyocarina/clip/ExquisiteSaltyPheasantSquadGoals-dl0ccNnxWglRkDiz
For the other boss doors this is not a problem because they all have some sort of floor collision that extend to at least match this range.
According to decomp, this was fixed in 1.1 by reducing the side range activation in the door_shutter actor. Likely to avoid this Forest voidout, or maybe just to make it match the texture better.
This PR ports back the value used in 1.1.
This actually impacts all boss doors and not only Forest since they all use the same actor. We could restrict it but that would involve a far more complex hack.
But this is a really small change which 99% of players won't probably ever notice, and it does make more sense visually. See the examples below :

Fire Boss door max side range at 70
fire_before

Max side range at 50
fire_after

Water Boss door 1.0 max side range at 70
water_before

Max side range at 50
water_after

Patches.py Outdated Show resolved Hide resolved
@fenhl fenhl added Type: Bug Something isn't working Status: Waiting for Author Changes or response requested Status: Needs Review Someone should be looking at it Component: Patching Affects the patching of the ROM labels Nov 17, 2024
@r0bd0g
Copy link

r0bd0g commented Nov 17, 2024

Does this change affect the doors in Jabu?
Is there a reason the doors in Jabu were adjusted in vanilla?

@GSKirox
Copy link
Collaborator Author

GSKirox commented Nov 17, 2024

The Jabu doors have separate values since it's a different behaviour from the boss ones, so it won't be affected by this change.
It was indeed also adjusted in 1.1, but i don't really know the reason. Maybe a similar bug?

@fenhl fenhl removed Status: Waiting for Author Changes or response requested Status: Needs Review Someone should be looking at it labels Nov 17, 2024
@fenhl fenhl added this to the next milestone Nov 17, 2024
@fenhl fenhl merged commit 0aa742b into OoTRandomizer:Dev Nov 17, 2024
3 checks passed
@mracsys mracsys mentioned this pull request Nov 18, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Patching Affects the patching of the ROM Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants