-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing easy-install plugin with bash script #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @propilideno! I was taking a look at your code, and had some problems while installing it with Windows. I mainly use Unix systems, however, I need to make sure the experience is good even on Windows machines.
The problem is when changing the path at functions read_App_Path()
and read_Plugin_Path()
. When answering with "n", it gives an error and does not allow the user to type a new path. I'm not sure what the reason is, but using another auxiliar variable seemed to fix it on what I tested.
Can you please fix it? If you can't, I will change it and approve your PR
Hello @matheuslenke, Best Regards, |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on 89196a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Tested and everything seems fine to me. Thanks for your contribution, really nice the file picker on Windows. Merging now |
Description
The goal of this pull request is:
Checklist
WhoAmI
I am Propi (Lucas de Almeida), i'd contributed with Open Source Projects and with Master's degree articles. I also have advanced skills in bash scripting and my changes are huge relevant for this project.
Feel free to contact me.
Changes made
Reused from FrameWeb-VP-Plugin Fork
pom.xml
to App dir and Plugin dir given directories or default path.You can check more informations about behavior in this pull request
My adaptations for OntoUML
get_VP_App_Path
andget_VP_Plugin_Path
functions.install_maven
because in OntoUML, maven is optional. So, we're installing with Maven WrapperTesting
Open
Git Bash
orTerminal
, and type:Final Thoughts
I refrained from including my name in the README file since I am not a member of the team. However, I would be honored if you would consider crediting me for my contributions.