Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated codes and upgrade dependency versions #12453

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

yiqing-zhao
Copy link
Contributor

@yiqing-zhao yiqing-zhao commented Sep 25, 2024

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/25506981

Remove deprecated codes and dependencies to avoid node checker warning in templates.
Update dependency versions and pacakge version.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 89.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (d8792ed) to head (42731ff).
Report is 49 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sdk/src/util/utils.ts 73.68% 0 Missing and 5 partials ⚠️
packages/sdk-react/src/useGraph.ts 0.00% 1 Missing ⚠️
.../sdk/src/conversation/sso/botSsoExecutionDialog.ts 50.00% 0 Missing and 1 partial ⚠️
...k/src/conversationWithCloudAdapter/notification.ts 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #12453      +/-   ##
==========================================
- Coverage   94.63%   89.72%   -4.91%     
==========================================
  Files         583      573      -10     
  Lines       34607    34020     -587     
  Branches     6694     6776      +82     
==========================================
- Hits        32751    30526    -2225     
+ Misses       1583     1535      -48     
- Partials      273     1959    +1686     
Files with missing lines Coverage Δ
packages/sdk-react/src/useData.ts 90.90% <ø> (-9.10%) ⬇️
packages/sdk-react/src/useTeams.ts 95.65% <100.00%> (-2.18%) ⬇️
packages/sdk-react/src/useTeamsUserCredential.ts 68.75% <ø> (-12.50%) ⬇️
packages/sdk/src/bot/teamsBotSsoPrompt.ts 86.55% <100.00%> (-6.51%) ⬇️
packages/sdk/src/conversation/interface.ts 100.00% <ø> (ø)
...c/conversation/middlewares/cardActionMiddleware.ts 55.55% <ø> (-17.78%) ⬇️
...ation/sso/defaultBotSsoExecutionActivityHandler.ts 70.96% <ø> (ø)
packages/sdk/src/conversation/storage.ts 82.14% <100.00%> (-11.20%) ⬇️
packages/sdk/src/core/errors.ts 100.00% <ø> (ø)
packages/sdk/src/credential/appCredential.ts 95.34% <100.00%> (-4.66%) ⬇️
... and 8 more

... and 277 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant