Skip to content

Commit

Permalink
Merge pull request #11035 from OfficeDev/supkasar-patch-1
Browse files Browse the repository at this point in the history
docs: Update package.nls.json
  • Loading branch information
supkasar authored Apr 4, 2024
2 parents 87cb797 + 210729c commit 18377bc
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
14 changes: 7 additions & 7 deletions packages/fx-core/resource/package.nls.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"core.provision.provision": "Provision",
"core.provision.learnMore": "Learn more",
"core.provision.learnMore": "More info",
"core.provision.azureAccount": "Azure account: %s",
"core.provision.azureSubscription": "Azure subscription: %s",
"core.provision.m365Account": "Microsoft 365 account: %s",
"core.provision.confirmEnvAndCostNotice": "Costs may apply based on usage. Do you want to provision resources in %s environment using listed accounts?",
"core.deploy.confirmEnvNoticeV3": "Do you want to deploy resources in %s environment?",
"core.provision.viewResources": "View provisioned resources",
"core.deploy.aadManifestSuccessNotice": "Your Microsoft Entra app has been deployed successfully. To view that, click \"Learn more\"",
"core.deploy.aadManifestSuccessNotice": "Your Microsoft Entra app has been deployed successfully. To view that, click \"More info\"",
"core.deploy.aadManifestOnCLISuccessNotice": "Your Microsoft Entra app has been updated successfully.",
"core.deploy.aadManifestLearnMore": "Learn more",
"core.deploy.botTroubleShoot": "To troubleshoot your bot application in Azure, click \"Learn more\" for documentation.",
"core.deploy.botTroubleShoot.learnMore": "Learn more",
"core.deploy.aadManifestLearnMore": "More info",
"core.deploy.botTroubleShoot": "To troubleshoot your bot application in Azure, click \"More info\" for documentation.",
"core.deploy.botTroubleShoot.learnMore": "More info",
"core.option.deploy": "Deploy",
"core.option.confirm": "Confirm",
"core.option.learnMore": "Learn more",
"core.option.learnMore": "More info",
"core.option.upgrade": "Upgrade",
"core.option.moreInfo": "More Info",
"core.progress.create": "Create",
Expand All @@ -37,7 +37,7 @@
"core.projectVersionChecker.cliUseNewVersion": "Your TeamFx CLI version is old and it doesn't support current project, please upgrade to the latest version using command below:\nnpm install -g @microsoft/teamsapp-cli@latest",
"core.projectVersionChecker.incompatibleProject": "The current project is incompatible with the installed version of Teams Toolkit.",
"core.projectVersionChecker.vs.incompatibleProject": "The project in the solution is created with Teams Toolkit preview feature - Teams App Configuration Improvements. You can turn on the preview feature to continue.",
"core.deployArmTemplates.ActionSuccess": "Successfully deployed ARM templates. Resource group name: %s. Deployment name: %s",
"core.deployArmTemplates.ActionSuccess": "ARM templates are deployed successfully. Resource group name: %s. Deployment name: %s",
"core.collaboration.ListCollaboratorsSuccess": "'List of Microsoft 365 App owners is successful, you can view it in [Output panel](%s).",
"core.collaboration.GrantingPermission": "Granting permission",
"core.collaboration.EmailCannotBeEmptyOrSame": "Provide collaborator's email and make sure it's not the current user's email.",
Expand Down
8 changes: 4 additions & 4 deletions packages/fx-core/tests/core/FxCore.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ describe("Core basic APIs", () => {

it("deploy aad manifest happy path", async () => {
const promtionOnVSC =
'Your Microsoft Entra app has been deployed successfully. To view that, click "Learn more"';
'Your Microsoft Entra app has been deployed successfully. To view that, click "More info"';

const core = new FxCore(tools);
const showMessage = sandbox.spy(tools.ui, "showMessage") as unknown as sinon.SinonSpy<
Expand Down Expand Up @@ -275,12 +275,12 @@ describe("Core basic APIs", () => {
assert.equal(showMessage.getCall(0).args[0], "info");
assert.equal(showMessage.getCall(0).args[1], promtionOnVSC);
assert.isFalse(showMessage.getCall(0).args[2]);
assert.equal(showMessage.getCall(0).args[3], "Learn more");
assert.equal(showMessage.getCall(0).args[3], "More info");
assert.isFalse(openUrl.called);
});
it("deploy aad manifest happy path with click learn more", async () => {
it("deploy aad manifest happy path with click more info", async () => {
const core = new FxCore(tools);
sandbox.stub(tools.ui, "showMessage").resolves(ok("Learn more"));
sandbox.stub(tools.ui, "showMessage").resolves(ok("More info"));
sandbox.stub(tools.ui, "openUrl").resolves(ok(true));
const appName = await mockV3Project();
sandbox
Expand Down

0 comments on commit 18377bc

Please sign in to comment.